On Sat, Sep 15, 2001 at 12:50:27AM +0200, GOMEZ Henri wrote:
> Hi to all,
>
> I've just commited updated code for Apache 1.3/2.0
>
> I will need a serious code review on Apache 2.0 part
> and particulary the ws_read() which was grabbed from
> 1.3 and works (at least on Apache 2.0.24) but may
> be optimized...
<snip, snip>
> ws_write() could need also a serious cleanup and see if the
> CHUNK_SIZE of 4k is still valid.
>
> /* Works with 4096, fails with 8192 */
> #define CHUNK_SIZE 4096
Should be no need for this chunking. Just pass it all to
ap_rwrite. If that doesn't work, then we have problem on our end
that we need to fix.
Since you have a "common" infrastructure via callbacks, I don't think
you can take advantage of a lot of the new features in Apache 2.0.
Oh, well. -- justin
