Re: Thread pool support

[Bojan Smojver]

Larry Isaacs wrote:
> 
> Hi Bojan,
> 
> The user's guide still has a lot of content that is out of date.
> You cite one of the sections that I haven't updated yet.
> 
> The reading of server.xml is controlled by ServerXmlReader.java
> found in "tomcat/modules/config".  See the setBackward() method
> at the end of the file for how the old syntax is supported.
> The syntax you request is now the standard.
> 
> If a module (a.k.a interceptor) has a setter, you can specify
> the corresponding property in server.xml.  Since PoolTcpConnector
> (which Ajp13Interceptor extends) contains setMaxThreads(),
> setMaxSpareThreads(), setMinSpareThreads(), etc. the syntax
> would be:
> 
> <Ajp13Connector maxThreads="50"
>                 maxSpareThreads="10"
>                 minSpareThreads="5"
>                 port="8009"
>                 address="127.0.0.1"/>
> 
> I believe it is the following lines in ServerXmlReader.addTagRule()
> that makes this possible:
> 
>         xh.addRule( tag ,
>                     xh.setProperties());
> 
> Hope this helps,

Yep, it does. Thanks.

Patch for the UG is attached.

Bojan
--- /home/groups/devel/jakarta/jakarta-tomcat/src/doc/tomcat-ug.html    Sat Aug 18 
11:25:01 2001
+++ tomcat-ug.html      Fri Aug 24 23:13:26 2001
@@ -1313,24 +1313,14 @@
             <td bgcolor="#c0c0c0">
 <pre>
         &lt;!-- (1) HTTP Connector for stand-alone operation --&gt;
-        &lt;Connector 
className=&quot;org.apache.tomcat.service.SimpleTcpConnector&quot;&gt;
-            &lt;Parameter
-                name=&quot;handler&quot;
-                
value=&quot;org.apache.tomcat.service.http.HttpConnectionHandler&quot;/&gt;
-            &lt;Parameter
-                name=&quot;port&quot;
-                value=&quot;8080&quot;/&gt;
-        &lt;/Connector&gt;
+        &lt;Http10Connector port=&quot;8080&quot;
+                         address=&quot;127.0.0.1&quot;
+        /&gt;
 
         &lt;!-- (2) AJPV12 Connector for out-of-process operation --&gt;
-        &lt;Connector 
className=&quot;org.apache.tomcat.service.SimpleTcpConnector&quot;&gt;
-            &lt;Parameter
-                name=&quot;handler&quot;
-                
value=&quot;org.apache.tomcat.service.connector.Ajp12ConnectionHandler&quot;/&gt;
-            &lt;Parameter
-                name=&quot;port&quot;
-                value=&quot;8007&quot;/&gt;
-        &lt;/Connector&gt;
+        &lt;Ajp12Connector port=&quot;8007&quot;
+                        address=&quot;127.0.0.1&quot;
+        /&gt;
 </pre>
             </td>
           </tr>
@@ -1417,14 +1407,9 @@
             <td bgcolor="#c0c0c0">
 
 <pre>&lt;!-- A pooled AJPV12 Connector for out-of-process operation --&gt;
-        &lt;Connector 
className=&quot;org.apache.tomcat.service.PoolTcpConnector&quot;&gt;
-            &lt;Parameter
-                name=&quot;handler&quot;
-                
value=&quot;org.apache.tomcat.service.connector.Ajp12ConnectionHandler&quot;/&gt;
-            &lt;Parameter
-                name=&quot;port&quot;
-                value=&quot;8007&quot;/&gt;
-        &lt;/Connector&gt;
+        &lt;Ajp12Connector port=&quot;8007&quot;
+                        address=&quot;127.0.0.1&quot;
+        /&gt;
 </pre>
             </td>
           </tr>
@@ -1454,23 +1439,13 @@
             <td bgcolor="#c0c0c0">
 <pre>
         &lt;!-- A pooled AJPV12 Connector for out-of-process operation --&gt;
-        &lt;Connector 
className=&quot;org.apache.tomcat.service.PoolTcpConnector&quot;&gt;
-            &lt;Parameter
-                name=&quot;handler&quot;
-                
value=&quot;org.apache.tomcat.service.connector.Ajp12ConnectionHandler&quot;/&gt;
-            &lt;Parameter
-                name=&quot;port&quot;
-                value=&quot;8007&quot;/&gt;
-            &lt;Parameter
-                name=&quot;max_threads&quot;
-                value=&quot;30&quot;/&gt;
-            &lt;Parameter
-                name=&quot;max_spare_threads&quot;
-                value=&quot;20&quot;/&gt;
-            &lt;Parameter
-                name=&quot;min_spare_threads&quot;
-                value=&quot;5&quot; /&gt;
-        &lt;/Connector&gt;
+        &lt;Ajp12Connector tomcatAuthentication=&quot;false&quot;
+                        port=&quot;8007&quot;
+                        address=&quot;127.0.0.1&quot;
+                        maxThreads=&quot;30&quot;
+                        maxSpareThreads=&quot;20&quot;
+                        minSpareThreads=&quot;5&quot;
+        /&gt;
 </pre>
             </td>
           </tr>