| This breaks query strings.
| 
| r->uri contains only the path portion of the URL.  r->unparsed_uri
| contains the URL in its "virgin" format - as sent by the client.

No, I don't believe this is quite right.
getRequestURI() in a servlet should return 
r->unparsed_uri minus a query string.

Setting s->uri = r->uri doesn't break
query strings.. but it *does* break the
encoding of the uri.

So tc 3.3 is currently broken as is mod_webapp
(unless the string is encoded on the java side
 in TC4).

However, Justin, I think your suggestion is
the correct solution:

    s->req_uri = ap_encode_uri(r->pool, r->uri);

David, or anyone else interested too, would you
try this with some corner test cases and see if
it lives up to expectation?

Keith

Reply via email to