clucas 01/05/11 11:43:41
Modified: src/share/org/apache/jasper/compiler TagPoolGenerator.java
TagPoolManagerGenerator.java
src/share/org/apache/jasper/runtime TagHandlerPool.java
TagHandlerPoolImpl.java TagPoolManager.java
TagPoolManagerImpl.java
Log:
minor comment / javadoc fixes
Revision Changes Path
1.3 +15 -13
jakarta-tomcat/src/share/org/apache/jasper/compiler/TagPoolGenerator.java
Index: TagPoolGenerator.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagPoolGenerator.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- TagPoolGenerator.java 2001/04/28 21:13:36 1.2
+++ TagPoolGenerator.java 2001/05/11 18:42:54 1.3
@@ -1,4 +1,8 @@
/*
+ * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagPoolGenerator.java,v
1.3 2001/05/11 18:42:54 clucas Exp $
+ *
+ * ====================================================================
+ *
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
@@ -68,7 +72,7 @@
* during jsp initialization.
*
* @author Casey Lucas <[EMAIL PROTECTED]>
- * @see TagPoolManager
+ * @see org.apache.jasper.runtime.TagPoolManager
*/
public class TagPoolGenerator extends GeneratorBase
implements ClassDeclarationPhase, InitMethodPhase {
@@ -118,11 +122,11 @@
* This method returns a unique pool name based on the given
* TagLibraryInfo, TagInfo, and set of tag attributes. Tag
* attribute order does not affect the returned name.
- *
+ *
* @param tli
* @param ti
* @param attributes
- * @return
+ * @return unique pool name based on parameters
*/
public static String getPoolName(TagLibraryInfo tli, TagInfo ti, Hashtable
attributes) {
return getSafeVariableName(tli.getURI() + "_" + ti.getTagName() +
getStringFromAttributes(attributes));
@@ -132,12 +136,11 @@
/**
* This method returns a unique pool variable name given
* TagLibraryInfo, TagInfo and set of tag attributes.
- *
+ *
* @param tli
* @param ti
* @param attributes
- * @return
- * @see getPoolName
+ * @return unique pool variable name based on parameters
*/
public static String getPoolVariableName(TagLibraryInfo tli, TagInfo ti,
Hashtable attributes) {
return getPoolVariableName(getPoolName(tli, ti, attributes));
@@ -147,10 +150,9 @@
/**
* This method returns a unique pool variable name given
* a unique pool name
- *
+ *
* @param poolName
- * @return
- * @see getPoolName
+ * @return unique pool variable name
*/
public static String getPoolVariableName(String poolName) {
return getSafeVariableName(POOL_VARIABLE_NAME_PREFIX + poolName);
@@ -187,9 +189,9 @@
/**
* This method generates a string based on a set of tag attributes.
* It sorts the attributes by name then concatenates them.
- *
+ *
* @param attributes
- * @return
+ * @return string based on tag attributes
*/
private static String getStringFromAttributes(Hashtable attributes) {
if (attributes == null || attributes.isEmpty()) {
@@ -240,9 +242,9 @@
* This method generates a string that can be used as a java
* variable name. Characters that cant be used are replaced
* with an underscore.
- *
+ *
* @param s
- * @return
+ * @return string that can be used as java variable name
*/
private static String getSafeVariableName(String s) {
StringBuffer buffer = new StringBuffer();
1.3 +5 -1
jakarta-tomcat/src/share/org/apache/jasper/compiler/TagPoolManagerGenerator.java
Index: TagPoolManagerGenerator.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagPoolManagerGenerator.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- TagPoolManagerGenerator.java 2001/04/28 21:13:36 1.2
+++ TagPoolManagerGenerator.java 2001/05/11 18:42:57 1.3
@@ -1,4 +1,8 @@
/*
+ * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/TagPoolManagerGenerator.java,v
1.3 2001/05/11 18:42:57 clucas Exp $
+ *
+ * ====================================================================
+ *
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
@@ -63,7 +67,7 @@
* declares and attempts to obtain a TagPoolManager.
*
* @author Casey Lucas <[EMAIL PROTECTED]>
- * @see TagPoolManager
+ * @see org.apache.jasper.runtime.TagPoolManager
*/
public class TagPoolManagerGenerator extends GeneratorBase
implements InitMethodPhase {
1.2 +4 -0
jakarta-tomcat/src/share/org/apache/jasper/runtime/TagHandlerPool.java
Index: TagHandlerPool.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagHandlerPool.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TagHandlerPool.java 2001/03/24 06:49:30 1.1
+++ TagHandlerPool.java 2001/05/11 18:43:13 1.2
@@ -1,4 +1,8 @@
/*
+ * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagHandlerPool.java,v 1.2
2001/05/11 18:43:13 clucas Exp $
+ *
+ * ====================================================================
+ *
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
1.2 +4 -0
jakarta-tomcat/src/share/org/apache/jasper/runtime/TagHandlerPoolImpl.java
Index: TagHandlerPoolImpl.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagHandlerPoolImpl.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TagHandlerPoolImpl.java 2001/03/24 06:49:30 1.1
+++ TagHandlerPoolImpl.java 2001/05/11 18:43:18 1.2
@@ -1,4 +1,8 @@
/*
+ * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagHandlerPoolImpl.java,v
1.2 2001/05/11 18:43:18 clucas Exp $
+ *
+ * ====================================================================
+ *
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
1.2 +7 -3
jakarta-tomcat/src/share/org/apache/jasper/runtime/TagPoolManager.java
Index: TagPoolManager.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagPoolManager.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TagPoolManager.java 2001/03/24 06:49:30 1.1
+++ TagPoolManager.java 2001/05/11 18:43:21 1.2
@@ -1,4 +1,8 @@
/*
+ * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagPoolManager.java,v 1.2
2001/05/11 18:43:21 clucas Exp $
+ *
+ * ====================================================================
+ *
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
@@ -73,7 +77,7 @@
* </ul>
*
* @author Casey Lucas <[EMAIL PROTECTED]>
- * @see TagPoolManagerInterceptor
+ * @see org.apache.tomcat.facade.TagPoolManagerInterceptor
*/
public interface TagPoolManager {
@@ -86,11 +90,11 @@
/**
* Obtain a named pool. Each uniquely named pool holds tag
* handlers.
- *
+ *
* @param poolName unique name of the tag pool
* @param handlerClass
* the type of tag handler objects stored by the pool
- * @return
+ * @return the pool that should be used for this poolName and handlerClass
*/
public TagHandlerPool getPool(String poolName, Class handlerClass);
1.2 +6 -2
jakarta-tomcat/src/share/org/apache/jasper/runtime/TagPoolManagerImpl.java
Index: TagPoolManagerImpl.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagPoolManagerImpl.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- TagPoolManagerImpl.java 2001/03/24 06:49:30 1.1
+++ TagPoolManagerImpl.java 2001/05/11 18:43:24 1.2
@@ -1,4 +1,8 @@
/*
+ * $Header:
/home/cvs/jakarta-tomcat/src/share/org/apache/jasper/runtime/TagPoolManagerImpl.java,v
1.2 2001/05/11 18:43:24 clucas Exp $
+ *
+ * ====================================================================
+ *
* The Apache Software License, Version 1.1
*
* Copyright (c) 1999 The Apache Software Foundation. All rights
@@ -64,8 +68,8 @@
* It simply manages a collection of named pools, including their
* retrieval and cleanup.
*
- * @author Casey Lucas <[EMAIL PROTECTED]
- * @see TagPoolManagerInterceptor
+ * @author Casey Lucas <[EMAIL PROTECTED]>
+ * @see org.apache.tomcat.facade.TagPoolManagerInterceptor
*/
public class TagPoolManagerImpl implements TagPoolManager {
