Hello Henri, I participated in the mod_jk fdatasync discussion on Friday. I have 4 more mod_jk/ajp13 patches on my personal wishlist. The first three (these are mod_jk patches) apply to 3.2.2 as well as to 3.3-milestone2. The fourth (which is the tomcat ajp13 patch) is already fixed in 3.3, but not in 3.2.2. I describe the four and add some diff-output for 3.2.2-beta2. I'm not an experienced Java/C-developper, so do not blindly use the code, although all patches are very small. 1) In jk_ajp12_worker.c the HTTP return reason phrase (the text that belongs to the numeric status, like "OK" for "200") is not handled correct. If the phrase consists of more than one token, like "Not Found", only the first token is read from tomcat and returned to the client. (change two lines, add 5 lines) 2) I suggest adding a timestamp to mod_jk-logging in jk_util.c. Logging without a timestamp is not very useful. (change 1 line, add 2 lines) 3) I think in jk_uri_worker_map.c is a little bug. For me it loggs (very rarely) "NULL parameters" and looking at the code I can see, that the two places are exactly those, where the code does not return before the log statement, even if it succesfully completes the call. All other places where "NULL parameters" could be logged first try to do something successful, if yes return, if no do logging. So I think one gets the logging although it should not have happened. (delete 4 lines, change 3 lines, add 1 line) 4) In Ajp13ConnectorResponse.java the http reason phrase is missing in the returned status line. The change that has been done to tomcat 3.3 milestone 2, and maybe could be added to 3.2.2 also. (change 1 line) Maybe some of these could go into 3.2.2 or 3.3? Thanks Rainer
Ajp13ConnectorResponse.java_patch
kippdata informationstechnologie GmbH Bornheimer Straße 33a 53111 Bonn Tel.: 0228/98549-0 Fax: 0228/98549-50 email: [EMAIL PROTECTED]
