> -----Original Message-----
> From: Mel Martinez [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, March 28, 2001 6:41 PM
> To: [EMAIL PROTECTED]
> Subject: RE: TC3.3 Proposal: Refactoring org.apache.jasper.servlet
>
>
> Wow! I go away for a day and there is some great
> discussion on this thread!
>
> I've saved everybody's comments and will incorporate
> them into the proposal, which I will be working on
> tonight to formalize. When I've got it ready for
> review, I will put a proposal doc and any related
> files in html form into
> .../jakarta-tomcat/proposals/tomcat33/
>
doing some static analysis, based on class use of other classes, it looks
like this constellation of classes could easily be factored out into their
own package:
org.apache.jasper.compiler.Compiler
org.apache.jasper.compiler.Mangler
org.apache.jasper.compiler.CommandLineCompiler
org.apache.jasper.compiler.JspCompiler
org.apache.jasper.compiler.JavaCompiler
org.apache.jasper.compiler.JikesJavaCompiler
org.apache.jasper.compiler.SunJavaCompiler
org.apache.jasper.compiler.JspCompilationContext
org.apache.jasper.JspEngineContext
org.apache.jasper.CommandLineContext
org.apache.jasper.JasperEngineContext
Based on actual use, it looks to me like Mangler and Compiler should be
merged. There are no instances of Compiler that do not implement the Mangler
interface.
The classes that implement JspCompilationContext look to me like they don't
all belong in the same package, unless everything here is in the same
package. They are interface classes between the Jasper compiler and the
outside invoker of the compiler.
Here are the classes I'm talking about
http://www.panix.com/~sdowney/compilers.gif
and the entire compiler package
http://www.panix.com/~sdowney/org.apache.jasper.compiler.gif
(courtesy Together J)
<><><><><><><><><><><><><><><><><><><><><>This electronic mail transmission
may contain confidential information and is intended only for the person(s)
named. Any use, copying or disclosure by any other person is strictly
prohibited. If you have received this transmission in error, please notify
the sender via e-mail. <><><><><><><><><><><><><><><><><><><><><>
