--- "Ignacio J. Ortega" <[EMAIL PROTECTED]> wrote:
> Some comments on format and condign conventions ( in
> not the most
> appropiate for this :) :
>
> .- Wrap lines on the 80 chars boundary..
>
Oops! I did fine on the code - unfortunately went
over
on a couple of javadoc lines. Another comment line
that's over was not mine. I'll be sure to check this
in the future.
> .- Follow guidelines in
>
http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html
I'll assume you refer to the lack of guidelines
followed in the rest of the file (I didn't want to
sit there and rewrite everything). I did fix several
if()'s without braces.
>
> .- do not use tabs at all
>
I didn't know this (no tabs) was a tomcat guideline
(many of the source files already have tabs in them)
but I'll gladly stick to it from now on.
> I Know , i Know , this little comments can suppouse
> a flame bait :),
> everyone has his opinion perfectly admitible, but a
> unique coding style
> is a must in a project like Tomcat.., and it's on
> the guidelines..
>
I'm fine with that - but I don't see any real
guidelines applied at all to the code I've looked at.
Most notably, there is a noticeable lack of any effort
at javadoc comments throughout the code.
Not that I'm complaining. We all can do better.
Cheers,
Mel
__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail.
http://personal.mail.yahoo.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, email: [EMAIL PROTECTED]
