Hi Hans,

The patch is great, +1 from me. ( it's the way the code was supposed to
work - if you look back 2-3 revisions for that file you'll find very
similar code ). It seems the patch for "multiple session cookies" broke
this part - it's great that we fix it back.

For 3.3 we should probably move the code that extracts the session id from
cookies back to the request/SessionInterceptor ( and rename it
SessionIdInterceptor ).

Costin


>       // First check if we have a valid session ID from the URL, set 
>       // by the SessionInterceptor, and if so, set it as the request 
>       // session. If we have also received a valid session ID
>       // as a cookie, the next section of code will reset the session 
>       // to the one matching the ID found in the cookie.
>       String requestedSessionID = request.getRequestedSessionId();
>       if (requestedSessionID != null) {
>           System.out.println("Found a requested session ID: " +
> requestedSessionID);
>           sess = sM.findSession(requestedSessionID);
>           if (sess != null)
>              System.out.println("Found a requested session ID");
>               request.setSession(sess);
>       }
> 
>       // The current cookie checking code comes here
>       ...
> 
> Hans
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to