Hmm, thanks - judging by the last comments the guy in the ticket had some
misapprehensions about how tmux works. I think we should remove the S_ISDIR
check per Dmitry's diff since it is clearly unnecessary.
I think I'll also make tmux-%u under TMUX_TMPDIR unless some problem occurs to
me before I get home.
-------- Original message --------
From: Thomas Adam <tho...@xteddy.org>
Date:18/01/2015 21:15 (GMT+00:00)
To: Nicholas Marriott <nicholas.marri...@gmail.com>
Cc: Dmitri Paduchikh <dpaduch...@gmail.com>,tmux-users
<tmux-users@lists.sourceforge.net>
Subject: Re: [PATCH] The check of !S_ISDIR(sb.st_mode) in second time is wrong
since it's already known to be false at that point.
On 18 January 2015 at 20:32, Nicholas Marriott
<nicholas.marri...@gmail.com> wrote:
> I'm not sure what the original intent of the change was and I don't
> understand the commit message (below).
>
> It seems like the second !S_ISDIR check is both unnecessary and
> backwards... Thomas?
Seems it was related to this: https://sourceforge.net/p/tmux/tickets/66/
Hmm. I thought the steps to reproduce that were clear; perhaps not,
and perhaps my patch is effectively useless.
-- Thomas Adam
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
