Thanks for the quick feedback! I've attached an updated patch. –Anish
0001-Add-feature-to-enable-or-disable-keyboard-input.patch
Description: Binary data
> On Aug 7, 2014, at 1:01 PM, Nicholas Marriott <nicholas.marri...@gmail.com> > wrote: > > Ok but in that case you also need to add it to the last-pane synopsis. > > Also I don't see a need for any more one-line helper functions, just set > and clear the flag directly and do without server_enable/disable_input. > > This: > > + "[-ed] [-lDLRU] " CMD_TARGET_PANE_USAGE, > > Should be changed to -DdeLlRU (and manpage too of couse). > > Cheers > > >> On Thu, Aug 07, 2014 at 12:27:10PM -0700, Anish Athalye wrote: >> The last-pane section is also the part that runs if you `select-pane -l`. >> >> As the patch is now, running `select-pane -d -l` will disable input for the >> last pane that you were in. I think that behavior is more intuitive than >> having that function not work (because something like `select-pane -d -U` >> will still work). >> >> So I think it would be better to keep the patch as-is in that regard. Let me >> know if you still would like me to change it. >> >> Also, I did update the man page (tmux.1) in the previously attached patch. >> Let me know if the explanation should be modified. >> >> ???Anish >> >>> On Aug 7, 2014, at 12:10 PM, Nicholas Marriott >>> <nicholas.marri...@gmail.com> wrote: >>> >>> Hi >>> >>> You don't need to add these to the last-pane section as well, just to >>> select-pane. Also can you update the man page? >>> >>> Cheers >>> >>> >>> >>>> On Thu, Aug 07, 2014 at 04:09:30PM +0000, Anish R Athalye wrote: >>>> Oh, good idea. I think adding it to the select-pane command makes more >>>> sense. >>>> >>>> Please see attached patch. >>>> >>>> ?Anish >>> >>> >>>> >>>> >>>> >>>>> On Aug 7, 2014, at 8:16 AM, Nicholas Marriott >>>>> <nicholas.marri...@gmail.com> wrote: >>>>> >>>>> Please make this a flag or a pair of flags on an existing command. Maybe >>>>> select-pane or kill-pane. >>>>> >>>>> >>>>> >>>>>> On Thu, Aug 07, 2014 at 07:25:27AM +0000, Anish R Athalye wrote: >>>>>> Here?s a slightly modified version of the patch ? changed the interface >>>>>> slightly (better names). >>>>>> >>>>>> ?Anish >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> On Aug 6, 2014, at 11:58 PM, Anish R Athalye <aatha...@mit.edu> wrote: >>>>>>> >>>>>>> I think that it would be nice to have the ability to make specific >>>>>>> panes read only (switching from read/write). >>>>>>> >>>>>>> I?ve wanted this feature to keep myself from accidentally sending input >>>>>>> to certain processes that I?ve started in certain panes (that I?m just >>>>>>> monitoring). This would be great for things like long compilation >>>>>>> processes that should be monitored but shouldn?t accidentally be >>>>>>> disturbed. This could even be useful for making something like an htop >>>>>>> pane read only. >>>>>>> >>>>>>> It looks like there are some other people looking for this feature: >>>>>>> http://unix.stackexchange.com/questions/7588/is-there-a-tmux-shortcut-to-go-read-only >>>>>>> >>>>>>> If you?re happy with the change, the attached patch is good to go with >>>>>>> a `git am`. >>>>>>> >>>>>>> >>>>>>> ?Anish >>>>>>> >>>>>>> <0001-Implement-command-to-enable-disable-input.patch> >>>>>>> ------------------------------------------------------------------------------ >>>>>>> Infragistics Professional >>>>>>> Build stunning WinForms apps today! >>>>>>> Reboot your WinForms applications with our WinForms controls. >>>>>>> Build a bridge from your legacy apps to the future. >>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk_______________________________________________ >>>>>>> tmux-users mailing list >>>>>>> tmux-users@lists.sourceforge.net >>>>>>> https://lists.sourceforge.net/lists/listinfo/tmux-users >>>>> >>>>> >>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Infragistics Professional >>>>>> Build stunning WinForms apps today! >>>>>> Reboot your WinForms applications with our WinForms controls. >>>>>> Build a bridge from your legacy apps to the future. >>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk >>>>> >>>>>> _______________________________________________ >>>>>> tmux-users mailing list >>>>>> tmux-users@lists.sourceforge.net >>>>>> https://lists.sourceforge.net/lists/listinfo/tmux-users >>> >>> >>>
------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
