That would work for UTF-8 but unfortunately for ACS we need to use
smacs/rmacs so it has to be an attribute - unless you are suggesting
sending them for every ACS cell which would be inefficient.

This is probably the fix, but not tested.


Index: screen-write.c
===================================================================
RCS file: /cvs/src/usr.bin/tmux/screen-write.c,v
retrieving revision 1.69
diff -u -p -r1.69 screen-write.c
--- screen-write.c      17 Apr 2014 14:45:49 -0000      1.69
+++ screen-write.c      21 Jun 2014 23:55:59 -0000
@@ -990,6 +990,8 @@ screen_write_cell(struct screen_write_ct
                memcpy(&tmp_gc, &s->sel.cell, sizeof tmp_gc);
                grid_cell_get(gc, &ud);
                grid_cell_set(&tmp_gc, &ud);
+               tmp_gc.attr = tmp_gc.attr & ~GRID_ATTR_CHARSET;
+               tmp_gc.attr |= gc->attr & GRID_ATTR_CHARSET;
                tmp_gc.flags = gc->flags & ~(GRID_FLAG_FG256|GRID_FLAG_BG256);
                tmp_gc.flags |= s->sel.cell.flags &
                    (GRID_FLAG_FG256|GRID_FLAG_BG256);



On Sat, Jun 21, 2014 at 12:25:51PM +0100, Balazs Kezes wrote:
> On 2014-06-17 21:00 +0000, Egmont Koblinger wrote:
> > Inside tmux (current git) execute
> > echo -e '\e(0lqqqk'
> >
> > Line drawing characters appear on the screen:
> > ???????????????
> >
> > Now highlight with the mouse (tmux's builtin mouse handling).
> >
> > Expected behavior: they stay line drawing characters.
> >
> > Actual behavior: they become lqqqk instead.
> 
> Nick: Is there any reason why in the code ACS is a cell attribute rather
> than just directly writing the translated characters into the cell data?
> I think the latter would simplify the code a bit also fixing this
> particular bug.
> 
> -- 
> Balazs
> 
> ------------------------------------------------------------------------------
> HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
> Find What Matters Most in Your Big Data with HPCC Systems
> Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
> Leverages Graph Analysis for Fast Processing & Easy Data Exploration
> http://p.sf.net/sfu/hpccsystems
> _______________________________________________
> tmux-users mailing list
> tmux-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tmux-users

------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to