Hi,
I left my tmux sessions live while I was away for 2 weeks and saw that the
tmux_fork_proved file was created.

Here are the info

pparissis at poseidonas in ~ *130
ls -ls /tmp/tmux_fork_proved
0 -rw-r--r-- 1 pparissis pparissis 0 Apr 15 05:37 /tmp/tmux_fork_proved
pparissis at poseidonas in ~
cat !$
cat /tmp/tmux_fork_proved
pparissis at poseidonas in ~

attached files
tmux.fd = lsof for tmux process
tmux.server.info = output of tmux info

I know that Nicholas has already reported that he fixed some leaks, but I
thought it could be useful for Kezes.

Cheers,
Pavlos



On 13 April 2014 14:20, Pavlos Parissis <pavlos.paris...@gmail.com> wrote:

> On 12/04/2014 10:49 μμ, Balazs Kezes wrote:
> > On 2014-04-07 13:54 +0200, Pavlos Parissis wrote:
> >> Let me know what I else I can do in order to help troubleshooting
> >> this.
> >
> > So I've skimmed the source again and now I've found an actual leak but
> > I'm not sure you are hitting this or not. If the fork() in job_run()
> > fails then tmux will definitely leak 2 fds. Is it possible that you have
> > low process limits or huge amounts of processes or too little memory to
> > fork?
> >
> > Before fixing this particular leak here's what we can do to eliminate or
> > prove this theory for your case. Check out the latest sources and apply
> > the following to it:
> >
> > diff --git a/job.c b/job.c
> > index d7bd852..027a21d 100644
> > --- a/job.c
> > +++ b/job.c
> > @@ -58,6 +58,7 @@ job_run(const char *cmd, struct session *s,
> >
> >       switch (pid = fork()) {
> >       case -1:
> > +             open("/tmp/tmux_fork_proved", O_WRONLY|O_CREAT, 0666);
> >               environ_free(&env);
> >               return (NULL);
> >       case 0:         /* child */
> >
> > Then recompile, install and restart your tmux server. When you start
> > seeing leaking fds again just check for the above file whether it exists
> > and then report back.
> >
> > Thank you!
> >
>
> Patched applied, code was compiled, server was restarted and now I am
> waiting.
>
> Thanks,
> Pavlos
>
>
>

Attachment: tmux.fd
Description: Binary data

Attachment: tmux.server.info
Description: Binary data

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to