Hi folks, Am 14.11.2013 um 12:08 schrieb Dagobert Michelsen <d...@opencsw.org>: > I noticed that the latest version in GIT uses "open" with O_DIRECTORY which is > not available on Solaris. As a quick fix I have a conditional use of that > define > as merge request: > https://sourceforge.net/p/tmux/tmux-code/merge-requests/6/
Any chance of inclusion?
After some more research a colleague suggested that the correct replacement of
O_DIRECTORY would be
> #ifndef O_DIRECTORY /* Fail if not a directory */
> # define O_DIRECTORY 0
> #endif
>
> int f = open(dirname, O_DIRECTORY);
> #if O_DIRECTORY != 0
> if (f >= 0) {
> fstat(f, &sb);
> if (!S_ISDIR(sb.st_mode)) {
> flose(f);
> f = -1;
> errno = ENOTDIR;
> }
> }
> #endif
I can change the patch accordingly if this would be preferred.
> To catch issues on Solaris earlier I have set up buildbot to continously build
> versions of tmux on every commit:
> http://buildbot.opencsw.org:8010/waterfall
> The buildbot can send out notifications (email/irc/...) when a build failure
> occurs and has also pssobilities to test patches without committing them.
> I'll happily set this up if you think that would be useful.
Best regards
-- Dago
--
"You don't become great by trying to be great, you become great by wanting to
do something,
and then doing it so hard that you become great in the process." - xkcd #896
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
