On Thu, Nov 08, 2012 at 04:33:37AM +0000, Ben Boeckel wrote: > On Wed, Nov 07, 2012 at 15:13:21 GMT, Thomas Adam wrote: > >> $optflag_a && nwopts="-a -t $winid $nwopts" > > > > It is perhaps preferrable to not treat optflag_a as some literal boolean, > > but rather use something like: > > > > [ -n "$optflag_a" ] && nwopts="-a -t $winid $nwopts" > > I tend to use `true` and `false` for booleans. It's an exec either way.
[ is typically a shell builtin. > It also allows for some option to determing the `-a` argument in some > more complex way. > > >> if target=$(echo $pmtable | tr : "\n" | \ > >> grep -E "(=|^)$paneid(=|$)" | head -n 1 | grep .) ; then > > > > > > Ugh. :) What is this trying to do? (I know what it's doing, it's a > > rhetorical question). At this point, the "if" condition is wholly > > incorrect. I suggest this: > > It seems to be trying to count matches. The `-q` and `-c` flags should > be used instead. > > -- Ben > > > ------------------------------------------------------------------------------ > Everyone hates slow websites. So do we. > Make your web apps faster with AppDynamics > Download AppDynamics Lite for free today: > http://p.sf.net/sfu/appdyn_d2d_nov > _______________________________________________ > tmux-users mailing list > tmux-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tmux-users ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_nov _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
