Hi,

On 8 July 2012 09:04, Nicholas Marriott <nicholas.marri...@gmail.com> wrote:
> Hi
>
> I like this, just a few things:
>
> - I think choose-session and choose-window should look unchanged, no
>   extra flags - you can just convert format from -F.

Done.

> - The flags should be -w and -s and the formats -W and -S. I think this
>   matches set-option more closely.

Done.

> - If I give -w I want windows, -s sessions. If I give neither I want the
>   full tree (so no flags is the same as -ws).

Done.

> - I don't get how the ACS works for you, for me it just shows tq. It may
>   be too much work to turn them on properly and better just to use ->.

It works great for me.  I've tried for a compromise though, which you
might reject.  :)  I've moved some #defines from tty.c to tmux.h, one
of them being tty_use_acs() and am using that to determine if ACS line
chars should be used, defaulting to ASCII if that check fails.  I know
it's probably a little overkill, but I really like the ACS rendering.
But if you think it all a little too unnecessary, please feel free to
just make the ASCII version the default and drop the rest of the
checks.

See the "[PATCH 1/1] Further choose-tree improvements." email to
tmux-users@ which I've just sent.  Why I didn't just put the patch
here, I don't know.  Apologies for creating unnecessary work there, it
wasn't intentional.

I'm going to go and help my girlfriend cook dinner now, so I'll be
back after that, should you have any further comments/questions.

Thanks for looking at this, and being patient, I really appreciate it.

Kindly,

-- Thomas Adam

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to