Hi,
I've had these two patches kicking around for a while, so I've cleaned them
up and shoved them here for review.
[1/2]: Simplify server_window_check_bell()
This patch simplifies the code for window bell checks. Previously, the case
statement which differentiated the different bell types did the same thing,
the only difference being the status message, if visual-bell was set. This
patch combines the two.
[2/2]: Clear WINLINK_ALERTFLAGS across all sessions
It seems that in January 2012, a patch was applied to tmux to address
handling of alerts in the current window to only show when the session was
detached (OpenBSD patchset 1003). However, from what I can tell, this is
broken, not least of which it breaks linked windows across sessions, where
previously an alert in a linked window caused that alert to propagate to
_all_ sessions to which it is linked. With OpenBSD patchet 1003 however,
windows linked across sessions are cleared in all but the originating
window.
So this patch effectively does a few things:
1. Restores the functionality of alerting all instances of windows linked
to across multiple sessions.
2. Keeps the original intention of showing alerts on the current window if
that session is unattached. That is:
tmux lsw -t <some_unattached_session_id> -F \
'#{window_name}|#{window_flags}'
will show the current window as having an alert of some kind.
3. Introduces winlink_clear_flags() which is called from a few places when
selecting windows to clear all flags across winlinks.
Any questions, please ask.
-- Thomas Adam
Thomas Adam (2):
Simplify server_window_check_bell()
Clear WINLINK_ALERTFLAGS across all sessions
trunk/server-window.c | 55 ++++++++++++++-----------------------------------
trunk/session.c | 8 +++----
trunk/tmux.h | 2 ++
trunk/window.c | 31 ++++++++++++++++++++++++++++
4 files changed, 53 insertions(+), 43 deletions(-)
--
1.7.10
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
