On Fri, Jan 20, 2012 at 11:34 PM, Nicholas Marriott <nicholas.marri...@gmail.com> wrote: > Hi > > I got it now. Thanks. > > This mostly looks fine aside from style nits which will be easy to sort > out, although I'll wait to see the diff to see what impact it has > outside control.c. > > You will need to add your copyright line to the top of control.c and the > other new files.
Done. > For new commands, if they aren't useful outside control mode I would > consider renaming them to add eg a control- prefix, or hiding them all > under an umbrella control-mode-command or something. I changed dump-state and set-control-client-attr to control. > I would probably only document -C in the man page for the moment and any > of the new commands which would be useful outside control clients. Done. > I'll have to test it at some point too. I suppose it won't do me too > much harm to use OS X for a bit... Careful, iTerm2 is highly addictive :) > Are there any parts we can break off and commit separately to make the > diff smaller? For example the layout and join pane changes. I should write a doc for you describing what I did and why, and as part of that I'll figure out how this can be divided up. ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
