Hi,

I just reviwed the whole document and I agree it is ready for WGLC. I just 
found very minor things.

I think it would be good to inform the reader that with knowledge of 
"_TRAFFIC_SECRET_N", all subsequent application data traffic secret can be 
derived without any additional information. Otherwise reader might think they 
need to log all the traffic secrets.

I made a PR while revieing. Use as you wish.

https://github.com/tlswg/sslkeylogfile/pull/6

Cheers,
John Preuß Mattsson

From: TLS <tls-boun...@ietf.org> on behalf of Martin Thomson 
<m...@lowentropy.net>
Date: Monday, 29 January 2024 at 22:59
To: Salz, Rich <rsalz=40akamai....@dmarc.ietf.org>, tls@ietf.org <tls@ietf.org>
Subject: Re: [TLS] I-D Action: draft-ietf-tls-keylogfile-00.txt
On Fri, Jan 26, 2024, at 02:36, Salz, Rich wrote:
>> Internet-Draft draft-ietf-tls-keylogfile-00.txt is now available. It is a 
>> work
>> item of the Transport Layer Security (TLS) WG of the IETF.
>
> I assume this just documents the current format and that therefore
> existing implementations (OpenSSL and Wireshark come to mind) just work.

That's exactly right.  I'm not looking to add features.

> If that assumption is true, this seems ready for WGLC.

I agree.

_______________________________________________
TLS mailing list
TLS@ietf.org
https://www.ietf.org/mailman/listinfo/tls
_______________________________________________
TLS mailing list
TLS@ietf.org
https://www.ietf.org/mailman/listinfo/tls

Reply via email to