Hi Stephane, I am just looking into your code.
The idea of your changes is clear to me. There are some problems and questions so far: - Any existing contest rules for ARRL10M and ARRL160m seems to be affected. They do set dx_arrlsections via DX_&_SECTIONS but are not recognized via the CONTEST_IS_ARRLDX macro. And they have similar rules in not accepting W/VE country as a multiplier. Worked sections are counted and shown in the remaining sections list but not recorded in the logline. - There are some related questions to the problem. There are some other contests with sections and DX countries as multipliers. Some of them count the own country as mult AND a possible section, some (like ARRLDX) only the section OR foreign DX countries. We need a way to express that difference. - A second question comes from the change from strstr to strcmp in changepars(). Is it really needed that we have an exact match? Is it possible for sections with 2 characters to be a substring of a longer one? Anyway, your problem needs to be solved. I will make a branch for experimentation and discussion on github from your patch and add an issue. The DX_&_SECTION problem needs to be sorted out. 73, de Tom DL1JBE Am Sun, 28 Feb 2021 23:07:17 +0100 schrieb Stephane Fillod <f8...@free.fr>: > Hi, > > I've been participating into the french contest "Coupe du REF" this > weekend, a lot of fun. > Even though I've been using TLF since long time, only this week-end I > took the time > to write a fully working rule file, well sort-of. > > Let's start first in this mail with multipliers/section. I wanted to > track wanted sections. > Using TLF freshly built from git tree, I've been unable to configure > this rule : > /Multiplier is DXCC country or section from multiplier file, > basically a list of french departments./ > This should be covered by these statements : > > DX_&_SECTIONS > SERIAL_OR_SECTION > MULT_LIST=ref_deptmults > > Loading an existing logfile would leave the "Sect" line flat, the > "Show multipliers" screen > would be empty. However, logging new QSO would increment the Section > stats and multi screen. > > Diving into the source code, it looks like the statement > DX_&_SECTIONS is very tied to ARRL contests, > certainly for historical reasons. This is what is revealed by the > variable dx_arrlsections > set by cfg_dx_n_sections(). I've made a quick fix, please see > attached file tlf_dx_sections_quick_fix.patch > I tried to not break existing contest rules, however I haven't tested > them. I can make a fork for that, but IMO it'd be better to split the > dx_arrlsections variable as > something like one variable dx_arrl_contest and one dx_and_sections. > What do you think about it ? > > The fixes in src/changepars.c would enable the "Show multipliers" > screen, and also not misinterpret serial numbers as section (a test > has to be done to not break existing contest rules). > > The issue #235[2] might benefit from this fix. > > [1] > https://concours.r-e-f.org/reglements/actuels/reg_cdfhf_fr_202011.pdf > [2] https://github.com/Tlf/tlf/issues/235 (Mults on bandmap with > custom rules) > > Anyway, thanks for maintaining and improving TLF over the years. > Last year, TLF was merely crashing (stack smashing,..) at moment, > I see a lot of work has been done since. It's much appreciated! > > 73 > Stephane, F8CFE > -- "Do what is needful!" Ursula LeGuin: Earthsea --
