Hi Thomas, On Fri, Oct 19, 2018 at 06:23:39AM +0200, Thomas Beierlein wrote: > Hi Ervin, > > finally I find time to answer. Sorry for the delay.
no problem :) > Am Sat, 13 Oct 2018 18:15:22 +0200 > > ok - what should we do? After first and quick review I thought we > > can make a new function in callinput.c, called sethiscall(), > > which waits a string, and sets the hiscall. All other function in > > different threads collects the callsign in a local buffer, and > > call this function. This new function should rentrant and thread > > safe... any idea? > > > I think there is a better way. Copy the call in fldigi_get_log_call() > into an intermediate buffer and set a flag. During callinput() we pick > that up and bring it to hiscall. The access to the buffer can be > protected by a mutex and so made thread safe. > > The advantage in these scheme is that we have control when we change > hiscall. Otherwise it may be possible that fldigi_get_log_call() does > change it during some unrelated operation (e.g. writing the last QSO to > disk or similar). thanks - I think I understand it, and will try to made as soon. As I reviewed the code, we have to modify the getexchange() function as similar mode with "comment" variable. 73, Ervin _______________________________________________ Tlf-devel mailing list Tlf-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/tlf-devel
