Hello Thomas, first: thank you for the instructions and remarks,
On Tue, Oct 29, 2013 at 07:05:55AM +0100, Thomas Beierlein wrote: > Hi Ervin, > > nice to see the WAEDC going forward. I am looking forward with great > interest. > > At the moment I am a little bit busy with QRL here. So I can do a more > thorough test only in next days. > > For the moment I had only a quick look and would like to make some small > comments which may be helpful. absolutely :) > - The boilerplate in your new files seems to be a simple copy of Reins > original files. So the copyright is not quite right. As these files > are your work you should state so, e.g. > > 'Copyright (C) 2013 Ervin Hegedüs' well, I wanted to ask anyway about the copyright, but you preceded :). I will change it all of the affected files in the final version. And, by the way: what about those files, which I modified the original files, and contains Reins and/or you? Just simply had to add myself? > - I am not quite sure if the ALT+S and ALT+R key combinations are a > good choice. They are used already in tlf for another function. We > should look how to handle that best. ok, I agree - what is your suggestion? NB: the ALT+S and ALT+R combination aren't used in exchange field, so they are used only with this context. But if anybody has a good idea, I will change it. > - For logging it may be better to use glib's message logging > facility instead of the system log. That seems to be the wrong place > for messages from an normal application. Basicly I don't need to syslog(). I just use that for debug, to see some information about the variables. May be there are several ways to catch it, but I'm not a C programmer - I think I didn't coded in C in last 10 years or more... (Perhaps about 3 years ago I had to make a Python module in C - but it was not a complex code like Tlf. :)) The final version will not contains them, I want to purge the syslog.h header too from all affected files. > - In your first changes you made a functione named 'waedc_pa'. I think > it is modelled after the 'pacc_pa' function. That other function is > for the '_pa' part of the 'pacc' contest. So maybe a better name for > your function may be 'waedc_eu'. What do you think? You're absolutely right, I will change that name. Thank you again for the remarks, 73: Ervin HA2OS > 73, de Tom DL1JBE. > > > Am Mon, 28 Oct 2013 11:38:41 +0100 > schrieb Ervin Hegedüs - HA2OS <airw...@gmail.com>: > > > Dear HAM's, > > > > I didn't know as much time as I would have liked effort required > > to WAEDC-QTC patch, but now I think the part of code is ready to > > test it. > > > > The code is available from here: > > > > https://github.com/airween/tlf/tree/waedc-qtc > > > > (You need the git, autotools, GCC and make programs.) > > > > What it knows: > > - forked from waedc branch, which handle points and multi's > > - currently only the send directions working > > - actually, the Tlf _doesn't_ send really the QTC's, so just > > handles the lists, so you can try it bravely. > > > > Short intro, if somebody wants to helps to test it: > > > > - here is a logcfg.dat, rules, and a short log, if you don't want > > to make it from scratch: > > https://www.dropbox.com/sh/gmdt53ygrf5leh4/GwFFU95tpw > > - you can send QTC from only the current QSO, that mean you can't > > send when you save the last QSO (and go to edit it) > > - only can send QTC, when the callsign field is filled, and the > > active field is exchange number > > - then, if you want to send QTC, press ALT+S - the QTC send > > window will open (ALT+S means Send, ALT+R means Receive) > > - there is the current callsign, QTC serial, and number of QTC's > > - current callsign will be excluded from QTC list, and will send > > next time > > - if you press F2, all QTC's will be sent, and will marked with > > an asterix (*) the end of line > > - if you press ENTER, you can send it one by one (eg. repeat onyl > > one or more QTC) > > - if some QTC has not been sent, you can unmark is with DELETE > > - if you press ESC, QTC window will disappear; then if you press > > again ALT+S, and you will see the marked (sent) members > > - if you hide the QTC window, and press ENTER (save the contest > > QSO), QTC list will be saved with QSO > > - if you exit the program and start it again, QTC log will be > > parsed, and next QTC will generated by from the next block > > (excluding the current callsign again...) > > > > If you have _ANY_ question, bug report, or feature request, just > > plese send me an e-mail. > > > > Now I will start to make the receive direction, and connect to > > RTTY program (I'm using gMFSK). > > > > > > Thanks for the helps :) > > > > > > 73: > > > > > > Ervin > > HA2OS > > > > > > > > > > -- > "Do what is needful!" > Ursula LeGuin: Earthsea > -- > -- I � UTF-8 _______________________________________________ Tlf-devel mailing list Tlf-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/tlf-devel
