Hi Tom,

Thanks for taking care of tlf.

Sat, Dec 04, 2010, Thomas Beierlein skribis:
> Please find a new prerelease version 5 for TLF-1.0.0 at 
> 
> http://www.staff.hs-mittweida.de/~tb/tlf-1.0.0pre5.tar.gz
> 
> Changes:
> ========
> * Fixed some sporadic segfaults during write of markerfile for Xplanet
>   (Thanks to Olaf LA3RK for pointing me to the problem).
> * Fixed handling of MARKERDOTS and MARKERCALL configuration commands
>   (similar to MARKERS but with a slightly different representation in
>   Xplanet).
> * New 'callmaster' database and 'cty.dat' file (Thanks to Martin OK1RR).
> 
> As always, test reports and comments are welcome.

Please find attached a short patch fixing some cppcheck[1] (v1.44) warnings.

[1] http://cppcheck.wiki.sourceforge.net/

BTW, does the current TLF source base is available from a SVN repo?
I can't reach hermes.esrac.ele.tue.nl.

73
-- 
Stephane - F8CFE
diff -ru tlf-1.0.0pre5.orig/src/background_process.c tlf-1.0.0pre5/src/background_process.c
--- tlf-1.0.0pre5.orig/src/background_process.c	2010-01-17 10:21:45.000000000 +0100
+++ tlf-1.0.0pre5/src/background_process.c	2010-12-04 16:02:55.780833596 +0100
@@ -176,7 +176,7 @@
 		    lanspotflg = 0;
 		    break;
 		case TLFMSG:
-		    for (t = 0; t <= 4; t++)
+		    for (t = 0; t < 4; t++)
 			strcpy(talkarray[t], talkarray[t + 1]);
 
 		    talkarray[4][0] = lan_message[0];
diff -ru tlf-1.0.0pre5.orig/src/getexchange.c tlf-1.0.0pre5/src/getexchange.c
--- tlf-1.0.0pre5.orig/src/getexchange.c	2010-01-17 16:13:01.000000000 +0100
+++ tlf-1.0.0pre5/src/getexchange.c	2010-12-04 16:02:55.780833596 +0100
@@ -420,7 +420,7 @@
 
 /*  --------------------------------------------------------------------------*/
 
-char cmpattern[] = "                               ";	// global
+char cmpattern[32] = "                               ";	// global
 char ssexchange[30] = "";
 char section[8] = "";
 char callupdate[7];
@@ -452,7 +452,7 @@
     char serial[5] = "    ";
     char check[3] = "  ";
     char checksection[30];
-    char zone[] = "  ";
+    char zone[4] = "  ";
 
     char serpats[8][8] = {
 	"bfb",
diff -ru tlf-1.0.0pre5.orig/src/splitscreen.c tlf-1.0.0pre5/src/splitscreen.c
--- tlf-1.0.0pre5.orig/src/splitscreen.c	2010-02-08 20:31:16.000000000 +0100
+++ tlf-1.0.0pre5/src/splitscreen.c	2010-12-04 16:02:55.780833596 +0100
@@ -679,7 +679,7 @@
 		strcpy(s, spotline);
 	    }
 	} else {
-	    for (t = 0; t <= 4; t++)
+	    for (t = 0; t < 4; t++)
 		strcpy(talkarray[t], talkarray[t + 1]);
 	    if (s[strlen(s) - 1] == '\n')
 		s[strlen(s) - 1] = '\0';	// remove the newline
@@ -930,7 +930,7 @@
     wprintw(sclwin, "\n Use \":\" to go to tlf !! \n");
     wrefresh(sclwin);
 
-    for (iptr = 0; iptr <= MAX_SPOTS; iptr++)
+    for (iptr = 0; iptr < MAX_SPOTS; iptr++)
 	spot_ptr[iptr][0] = '\0';
 
     return (0);
_______________________________________________
Tlf-devel mailing list
Tlf-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/tlf-devel

Reply via email to