Hi gr,

I rewrote the history on a new review branch:

https://github.com/bold84/tinycc/tree/win_arm64_reviewable

The core Windows ARM64 work is now split into 9 themed commits (target 
bring-up, headers/tests, asm, symbolic opcode cleanup, GNU asm constraints, 
regression/self-hosting fixes, runtime work, nested -run fixes, final cleanup), 
instead of the original long history from win_arm64_clean.
I also compared your arm64-win32 branch against the rewritten series. Most of 
that branch is a condensed replay of the earlier Windows ARM64 work, so I kept 
the already validated 9-commit core series and then pulled over the parts that 
were distinct additions on your side.

Taken over from your branch:
tests/msvcrt_start.c
tests/test-win32.bat
win32/lib/winex.c
the small tests/Makefile hooks needed by test-win32.bat

Those are now on win_arm64_reviewable as:
851359c3 tests/win32: import grischka's Windows test helpers

I added Co-authored-by credit for that commit.

One note: I did not wire win32/lib/winex.c into the active runtime/library 
build on this branch, because doing so regressed nested Windows ARM64 -run 
coverage (tcc -run tcc.c ... -run ...). So the helper file is carried over, but 
the validated runtime path remains the current one.

For the rewritten branch I reran the ARM64 Windows validation plus the general 
test suite:
win32/build-tcc.bat -t arm64 -c clang
the Windows ARM64 smoke/runtime tests
make test -k
make -C tests test2 test3
tests/test-win32.bat -c clang -t arm64

Builds are clean and those tests pass.

How to proceed? I seem to not be able to push to the mob branch… 🥺


Some personal context on why I ended up doing the work here:

My original goal was to get OpenCode running on Windows ARM64, which first led 
me to work on the Bun side. I submitted that work there. Instead of discussing 
it normally, the maintainer took that work, opened a separate PR, and merged it 
under his own name. Several of those commits were direct one-to-one copies of 
patches I had already authored and submitted. If useful, I can point to the 
corresponding commit pairs.

Once that happened, I had no interest in continuing to contribute the TCC side 
through Bun’s fork, because I did not want to spend more time preparing another 
PR there only to watch it get consumed in the same way again. By then I had 
already realized that Bun was only half of the problem anyway, because TCC also 
needed proper Windows ARM64 support.

So I made a deliberate decision not to continue downstream at Bun, but to 
contribute the compiler work at the actual upstream source instead. That is why 
I came to TinyCC directly and why I cleaned up the history here for review.

I enjoy saying openly that I used OpenAI Codex, specifically the GPT-5.4 model, 
heavily while developing and validating this contribution. Claude Opus just 
couldn’t do it. So there is a certain irony in watching code developed that way 
later getting merged downstream by Bun, which is now part of Anthropic. 🤓

In any case, the important part is that the work exists upstream in the right 
place.

Greetings,

Ben

> On 5 Apr 2026, at 01:07, Benjamin Oldenburg <[email protected]> 
> wrote:
> 
> Ah.. “success” means built without warnings and all tests pass. 
> 
>> On 5 Apr 2026, at 01:07, Benjamin Oldenburg <[email protected]> 
>> wrote:
>> 
>> Hi gr,
>> 
>> alright. I will rewrite the history accordingly. 
>> 
>> The current state for https://github.com/bold84/tinycc/tree/win_arm64_clean :
>> 
>> - arm64-win32
>> - Clang: success
>> - MinGW GCC: not run
>> - MSVC cl: success
>> - x86_64-win32
>> - Clang: not run
>> - MinGW GCC: success
>> - MSVC cl: success
>> Linux x86_64
>> - GCC: success
>> - Clang: not installed
>> Linux aarch64
>> - GCC: success
>> - Clang: not installed
>> macOS ARM64 (Darwin)
>> - Clang: success
>> 
>> Any other targets that need to be green?
>> 
>> Kind regards,
>> 
>> Ben
>> 
>> 
>>> On 5 Apr 2026, at 00:52, grischka <[email protected]> wrote:
>>> 
>>> On April 4, 2026 11:10:11 AM UTC, Benjamin Oldenburg 
>>> <[email protected]> wrote:
>>>> I can complete the implementation in 
>>>> https://github.com/bold84/tinycc/tree/win_arm64_clean if there’s a chance 
>>>> it will actually be merged.
>>> 
>>> Hi Ben,
>>> sure it will, great work.
>>> 
>>> It would make sense though if we could somewhat compress the history to say 
>>> less than 10 commits each addressing a theme such as for example generator, 
>>> asm, runtime, symbolic replacement, etc. (while omitting unrelated 
>>> whitespace changes and some stuff that we maybe dont really need also). 
>>> Just a suggestion though ;)
>>> 
>>> Some first approach of mine here:
>>> https://github.com/gr8001/tinycc/tree/arm64-win32
>>> 
>>> Greetings,
>>> -- gr
>>> 
>>>> 
>>>> Kind regards,
>>>> 
>>>> Ben
>>>> 
>>>> 
>> 
> 

_______________________________________________
Tinycc-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Reply via email to