> By the way I didn't delete any code from the core, I just enhanced 2 > conditions, so if people were to upgrade tiddlywiki they will just lose > those 2 little enhancements and TiddlyResearch will keep working with no > problems. >
This is not how overwriting shadow tiddlers works. When you overwrite a $:/core tiddler, it will continue to be overwritten with your version even if the core is updated. Thus, any bug fixes or improvements made in the core to the overwritten tiddler will not be picked up, and if there are dependencies between the changes made to the tiddler you have overwritten and other parts of the core, the TiddlyWiki file may fail to work as expected. The next version of TW already has changes in the Navigator widget. Therefore it is not good practice to overwrite an entire module such as $:/core/modules/widgets/navigator.js and I would recommend that you look into using the hook mechanism, or overwriting the specific method necessary in Navigator if hooks are not able to achieve your goals. -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/a8cd843a-100b-4d5b-a077-43f617f7c4a0n%40googlegroups.com.
