On Tue, Oct 17, 2023 at 06:13:30PM -0700, Andrew Hewus Fresh wrote:
> On Tue, Oct 17, 2023 at 05:10:44PM -0700, Greg Steuck wrote:
> > I just got myself a fresh snapshot with libncurses.so.15.0:
> > OpenBSD 7.4-current (GENERIC.MP) #1409: Tue Oct 17 17:08:49 MDT 2023
> >
> > I get some unhappiness now:
> > # pkg_add -ui
> > No progress meter: failed termcap loop
> > quirks-6.161 signed on 2023-10-16T11:16:03Z
> >
> > Fallout from the ncurses upgrade?
>
> Seems likely. I can reproduce with this code that's similar to
> what OpenBSD::ProgressMeter::Term does:
>
> $ perl -MPOSIX -MTerm::Cap -e 'Term::Cap->Tgetent({ OSPEED =>
> POSIX::Termios->new->getospeed })'
> failed termcap loop at att610+cvis at -e line 1.
>
> or even just:
>
> $ perl -MTerm::Cap -e 'Term::Cap->Tgetent'
>
> failed termcap loop at att610+cvis at -e line 1.
>
> Wow though, the only hits google has for that "failed termcap loop" is
> the file it is in so incredibly impressive.
It appears 20 years ago nobody expected this complicated an
/etc/termcap. This patch seems to fix the glitch.
It has been 32 since at least it was moved back from SVN to CVS in 2004
which is when git history stops.
https://github.com/jonathanstowe/Term-Cap/blob/3a1193a8c5457d0ca77ea43d1be73712303a359c/Cap.pm#L254
(I only needed to change this to 36, but how future proof is that?)
Comments, OK?
Index: gnu/usr.bin/perl/cpan/Term-Cap/Cap.pm
===================================================================
RCS file: /cvs/src/gnu/usr.bin/perl/cpan/Term-Cap/Cap.pm,v
retrieving revision 1.2
diff -u -p -r1.2 Cap.pm
--- gnu/usr.bin/perl/cpan/Term-Cap/Cap.pm 5 Feb 2017 00:32:03 -0000
1.2
+++ gnu/usr.bin/perl/cpan/Term-Cap/Cap.pm 18 Oct 2023 01:25:11 -0000
@@ -280,7 +280,7 @@ sub Tgetent
$first = 0; # first entry (keeps term name)
- $max = 32; # max :tc=...:'s
+ $max = 64; # max :tc=...:'s
if ($entry)
{
