On 2023/08/15 18:16, Vladimir 'phcoder' Serbinenko wrote: > Did I do something wrong and should send it to another list, CC someone or > did I do something stupid? 64-bit incompat feature is enabled on new ext4's > by default, at least on Ubuntu
It's the right list. However as ext2fs support is not much used by developers and there's no "maintainer" for this bit of code it's going to be more difficult to find a reviewer. > Le lun. 3 juil. 2023, 02:49, Vladimir 'phcoder' Serbinenko < > phco...@gmail.com> a écrit : > > > Hello, all attached patch implements feature 64-bit for ext2. This was > > enabled implicitly on my Ubuntu and probably on many other systems. Since > > it's an incompat feature lack of its support prevented the mount > > altogether. With this patch I was able to load install sets from my Ubuntu > > partition. I'm not a good person to comment on the code changes, but the diff doesn't follow style(9), at least there are over-long lines, and while I didn't find anything in particular in style(9) about the alignment around = in blocks of setting a bunch of variables (like in e2fs_cgload), it's more common in the kernel to use "var = assignment" without extra spaces to align.
