> Date: Tue, 01 Aug 2023 22:34:05 +0900 > From: SASANO Takayoshi <u...@mx5.nisiq.net> > > hi, > > > maybe add a note that the data sheet is wrong for dcdc3? > > The datasheet issue is written in Linux code at > https://elixir.bootlin.com/linux/v6.5-rc4/source/drivers/regulator/axp20x-regulator.c#L725 > > > /* > > * This is deviating from the datasheet. The values here are taken from the > > * BSP driver and have been confirmed by measurements. > > */ > > static const struct linear_range axp313a_dcdc3_ranges[] = { > > REGULATOR_LINEAR_RANGE(500000, 0, 70, 10000), > > REGULATOR_LINEAR_RANGE(1220000, 71, 102, 20000), > > }; > > It means 500-1200mV(10mV*70 step) and 1220-1840mV(20mV*31 step), > they want to say dcdc3's 1650-1840mV range is something strange. > > AXP313A datasheet clearly says that dcdc3 is 0.5-1.2V and 1.22-1.84V. > https://github.com/mangopi-sbc/aw-doc/blob/main/pmic/AXP313A_Datasheet_V1.0_cn.pdf > > So I think no need to add any notes.
Ah, I was looking at an older version of the datasheet (v0.1). Looks like they fixed it. So yes, your diff is good as-is. No need to add any notes. ok kettenis@
