> On, at least, some Chromebook PS/2 protocol is implemented by EC rather > than a real PS/2 controller. It works fine except for 2 things: > * Unusual layout like multimedia keys instead of F* > * Reset command returns garbage (usually last key) > This patch attempts to handle later as it stops keyboard from being > recognized at all. It works by checking getid if reset fails.
I was not aware of the reset behaviour. I suppose your logic makes sense. However, only Chromebook or other crap hardware would hit that "send a getid command" path, so I think we should only check for a 0xab/0x83 answer to that command, rather than six possible values for the first byte and ignoring the second byte. Have you checked that the Chromebook EC 8042 emulation returns 0xab/0x83 to the 0xf2 command? Miod
