On Wed, Jun 14, 2023 at 10:44:23AM +0200, Claudio Jeker wrote: > There is no real need to have print_host() with the extra arguments. > So convert the last remaining print_host() calls to use print_addr(). > I'm not entierly sure how to really test all these code paths but the > changes are failry simple.
Thanks for beating me to it... In ikev2_pld_cp() you need to garbage collect buf and replace its remaining uses by the appropriate print_addr(). In ikev2_print_id() it would seem more appropriate to use strlcat() instead of strlcpy() in the switch and and reserve the special dance of adjusting idstr and idstrlen for the /* XXX test */ path, but that should be done in a separate diff. other than that this looks good.
