On Mon, Jun 12, 2023 at 12:35:33PM +0200, Claudio Jeker wrote: > On Mon, Jun 12, 2023 at 12:18:19PM +0200, Theo Buehler wrote: > > On Mon, Jun 12, 2023 at 11:43:11AM +0200, Claudio Jeker wrote: > > > To generate the IMSG_CTL_SHOW_RIB_ATTR message just use attr_writebuf() > > > instead of going via ibuf_reserve() and attr_write(). > > > > > > While there make a pointer != NULL check more obvious. > > > > ok > > > > > @@ -2934,12 +2933,8 @@ rde_dump_rib_as(struct prefix *p, struct > > > IMSG_CTL_SHOW_RIB_ATTR, 0, pid, > > > attr_optlen(a))) == NULL) > > > > This is the last use of attr_optlen(). I don't mind it, but it might as > > well be inlined. > > Or just removed and replaced with 0. imsg_create() does not really care > about the lenght (apart from extra length checks). > I can funnel that into the same diff or do it as a 2nd step.
Right. You can land this diff in one, two or three steps. I'm fine with either :)
