On Thu, Apr 13, 2023 at 03:35:33PM +0200, Claudio Jeker wrote: > If you have better suggestions on how to work with such a blob I'm happy > to hear. I tried to keep the madness in one place and have a mostly sane > API on top.
I see and understand that and you did that wrapping probably as nicely as these RFCs' madness allows. I do have some vague ideas that I would like to discuss with you when we meet soon. > > #define FLOWSPEC_OP_NUM_FALSE 0x00 > > #define FLOWSPEC_OP_NUM_TRUE 0x07 > > > > and use them in the switch in flowspec_fmt_num_op(). > > Torn about that. The concept of TRUE and FALSE is so rediculously > stupid that I'm not sure it is something we should promote out of dark > basement it should remain in. Understood. The real reason I suggested it is that it would have made the true/false mistake more immediately obvious. I'm fine with 0 and 0x7 if you prefer that. > Updated version of the diff below. It includes now a few more formatting > functions. This looks good to me. I spent quite a bit of time on the code now and couldn't spot anything anymore. Let's land it and improve in tree as needed. ok tb
