On Mon, Apr 03, 2023 at 05:45:43PM +0300, Vitaliy Makkoveev wrote: > On Mon, Apr 03, 2023 at 02:12:45PM +0200, Alexander Bluhm wrote: > > Hi, > > > > The arp mbuf queue la_mq has its own mutex, la_hold_total uses > > atomic operations. So they don't need the global arp mutex. > > > > Pull them out of arp_mtx blocks to make clear what the scope of > > arp_mtx protection is. > > > > ok? > > > > According `arp_mtx' mutex(9) description, "llinfo_arp live time, > rt_llinfo and RTF_LLINFO are protected by arp_mtx". So why unlocked `la' > dereference within arpinvalidate() is safe?
You are right. Forget this diff. It is not important. Thanks for reminding me of my own comment :-) bluhm
