On 2023/03/16 17:01:27 +0100, Omar Polo <o...@omarpolo.com> wrote: > moving to tech@, +cc okan@ > > On 2023/03/16 11:07:26 +0100, Julien Blanchard <jul...@typed-hole.org> wrote: > > Hello, > > Here is a patch that fixes a weird semi-transparency issue some apps > > have when using cwm with a compositor. The issue seems to be that the > > highest significant byte of the color is not initialized. > > According to xwininfo alacritty has a depth of 32 and xterm has a > > depth of 24. When using a compositor the windows with a depth of 32 > > don't have the proper border color. > > > > [...] > > > > The same issue happens with all windows that have a depth of 32 > > (firefox, thunderbird...). > > It fixes the borders for firefox and chromium for me with xcompmgr and > doesn't seem to cause issue with the "other" windows (xterm, some gtk3 > stuff, ...), thanks! > > (reattaching Julien' diff)
(sorry for the delay) I've committed it with an ok from okan@, thank you! > Index: client.c > =================================================================== > RCS file: /home/cvs/xenocara/app/cwm/client.c,v > retrieving revision 1.266 > diff -u -p -r1.266 client.c > --- client.c 26 Feb 2022 15:19:18 -0000 1.266 > +++ client.c 16 Mar 2023 15:43:40 -0000 > @@ -596,7 +596,7 @@ client_draw_border(struct client_ctx *cc > pixel = sc->xftcolor[CWM_COLOR_BORDER_URGENCY].pixel; > > XSetWindowBorderWidth(X_Dpy, cc->win, (unsigned int)cc->bwidth); > - XSetWindowBorder(X_Dpy, cc->win, pixel); > + XSetWindowBorder(X_Dpy, cc->win, pixel | (0xffu << 24)); > } > > static void
