On Fri, Mar 10, 2023 at 09:35:19AM +0100, Claudio Jeker wrote: > This is mainly cleanup of the rtr code. Rename a few functions to be more > explicit (rtr_send_reset_query(), rtr_send_serial_query()) introduce a > function to reset the rtr cache (rtr_reset_cache()). The reset function > always resets the session_id now to ensure the next connection attempt > issues a RESET_QUERY message. Also the expire timer is now stopped since > there is nothing left to expire. The rtr_recalc() call is left for the > callee to do since it can be called once at the end. > > The other big change is in the FSM. During version negotiation consider > any spurious connection close as a version error. This fixes the problem > with older StayRTR/GoRTR servers.
It took me a moment to understand the change in the RTR_STATE_ERROR handling, but once I figured that one out, the rest became relatively easy to follow. I like it, ok tb
