On Wed, Mar 01, 2023 at 04:53:00PM +0000, Stuart Henderson wrote: > How about this? Show a strong psk in the example
... > -# psk "you-should-not-use-psk-authentication!" > +# psk "tyBNv13zuo3rg1WVXlaI1g1tTYNzwk962mMUYIvaLh2x8vvvyA" I strongly disagree with this change. Not only are you removing a note that psk authentication is a poor choice, but you're also providing a _specific_ and otherwise strong key in the example which new or unfamiliar users could _easily_ use believing that it was a good choice. (Which of course it would be, if it wasn't potentially being used by a large number of other OpenBSD installs in the wild.) This is one step away from adding a back-door. Nobody in their right mind is going to use a literal string: "you-should-not-use-psk-authentication!" as their key. But it's entirely plausible that someone would copy: "tyBNv13zuo3rg1WVXlaI1g1tTYNzwk962mMUYIvaLh2x8vvvyA" to their real config. Maybe they do it with the intention of changing it later, just to see iked working, but then forget to change it. If the key itself says, "you-should-not-use-psk-authentication!", then forgetting to change it is an order of magnitude more difficult. And anybody taking over administration of a system and seeing it would know to change it. Seeing your example gives no clue that it's a demo key rather than a locally generated one. Please, do not commit this part of the change. Otherwise we will start to see scanning attempts on the internet using the key you've provided.
