On Wed, Dec 28, 2022 at 07:48:29PM +0100, Jeremie Courreges-Anglas wrote:
> 
> To build src cleanly with clang-15 you'd need the diff below.  The
> alternative would be to patch our three zlib copies and wait for
> upstream to fix it.  A more comfortable alternative is to just neuter
> the warning.  -Wno-unknown-warning-option prevents llvm 13 from
> complaining that it doesn't know about -Wno-deprecated-non-prototype and
> should ease the transition.  I took care to only add this workaround on
> clang archs, and to respect the COMPILER_VERSION checks where due.

Thanks. As already mentioned in another thread, ansifying libz will
likely result in more pain when updating since madler has a tendency of
touching lots of lines. While I could probably cope with the conflicts,
I'd really rather not have additional hurdles when updating zlib.

It is unfortunate that this has to touch so many files, but given that
the build is organized the way it is, I don't see a better option.
Modifying files fully under our control surely is the lesser evil, so

ok tb

unless someone objects.

Reply via email to