Theo Buehler <t...@openbsd.org> wrote: > On Thu, Dec 22, 2022 at 11:39:41AM +1100, Jonathan Gray wrote: > > On Thu, Dec 22, 2022 at 01:20:32AM +0100, Theo Buehler wrote: > > > > Any concerns regarding the changes in libz? It introduces diff to > > > > upstream, but the recent commits seemed to indicate we have forked > > > > anyway? > > > > > > I've worked hard to keep the diff to upstream minimal. Why are these > > > changes needed? > > > > the warnings are from -Wdeprecated-non-prototype > > > > https://github.com/madler/zlib/issues/633 > > So, can't we fix this by adding -Wno-deprecated-non-prototype to the > kernel build and wait until madler converts upstream?
yes, very possible or we could decide that clang is jumping the gun on disabling some legal syntax, as well as trying to hunt down things they don't like but which are not actually harmful, and flip the compiler default back.
