On Wed, Dec 21, 2022 at 07:40:01AM +0000, Klemens Nanni wrote: > On Tue, Dec 20, 2022 at 08:24:29PM +0000, Jason McIntyre wrote: > > On Tue, Dec 20, 2022 at 06:24:45PM +0000, Klemens Nanni wrote: > > > > > > Feedback? OK? > > > > > > > ok, in general i'm fine with this. i do have some concerns though: > > New diff with all points addressed, see inline for explanations. >
trimming this, but briefly: ok for your diff. i think this is fine. but still one nit: > Index: usr.bin/csplit/csplit.1 > =================================================================== > RCS file: /cvs/src/usr.bin/csplit/csplit.1,v > retrieving revision 1.12 > diff -u -p -r1.12 csplit.1 > --- usr.bin/csplit/csplit.1 24 Oct 2015 15:32:50 -0000 1.12 > +++ usr.bin/csplit/csplit.1 21 Dec 2022 06:56:23 -0000 > @@ -37,14 +37,15 @@ > .Op Fl ks > .Op Fl f Ar prefix > .Op Fl n Ar number > -.Ar file args ... > +.Ar file > +.Ar arg ... > .Sh DESCRIPTION > The > .Nm > utility splits > .Ar file > -into pieces using the patterns > -.Ar args . > +into pieces using the pattern > +.Ar arg . > If > .Ar file > is > @@ -92,7 +93,7 @@ created. > .El > .Pp > The > -.Ar args > +.Ar arg > operands may be a combination of the following patterns: > .Bl -tag -width indent > .It Xo so, is "arg" an operand or operands? well, it depends how you are thinking of it. i would suggest we treat it as singular - it will read better, and i don;t think anyone will read this text and complain that it was misleading. jmc
