OK with me.
Jonathan Gray <[email protected]> wrote:
> pci ids for newer amdgpu parts may not be known as all non-radeon ati
> display ids are matched in newer versions of amdgpu.
>
> in dmesg unknown products take the form:
> vga1 at pci12 dev 0 function 0 vendor "ATI", unknown product 0x687f rev 0xc3
> vendor "ATI", unknown product 0x687f (class display subclass VGA, rev 0x03)
> at pci12 dev 0 function 0 not configured
> amdgpu0 at pci12 dev 0 function 0 vendor "ATI", unknown product 0x687f rev
> 0xc3
>
> The diff below will match when an unknown azalia device or other ATI
> device is present. Alternatively it could be more specific:
> ^vga*vendor "ATI", unknown product
> ^vendor "ATI", unknown product*class display
>
> ^amdgpu*"ATI", unknown product
> should already be covered by the "amdgpu" line of firmware_patterns
>
> Index: patterns.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/fw_update/patterns.c,v
> retrieving revision 1.5
> diff -u -p -r1.5 patterns.c
> --- patterns.c 17 Nov 2022 13:30:21 -0000 1.5
> +++ patterns.c 7 Dec 2022 00:44:39 -0000
> @@ -90,6 +90,7 @@ main(void)
> printf("%s\n", "acx");
> printf("%s\n", "amdgpu");
> print_devices("amdgpu", amdgpu_devices, nitems(amdgpu_devices));
> + printf("%s \"ATI\", unknown product\n", "amdgpu");
> printf("%s\n", "apple-boot ^cpu0*Apple");
> printf("%s\n", "athn");
> printf("%s\n", "bwfm");
>
