On Wed, Nov 30, 2022 at 07:48:35PM +0100, Theo Buehler wrote: > On Wed, Nov 30, 2022 at 07:05:25PM +0100, Claudio Jeker wrote: > > Change ometric_set_int_with_label() to ometric_set_int_with_labels(). > > In rpki-client I need to add more than one extra label and extending this > > interface seems to be the least ugly solution. > > I use C99 compound literals to make this less ugly and wrapped that magic > > into the macro EV(). IMO this is a compromise to keep the code short. > > What does EV stand for?
I started first to just use it for extra values. I wanted something short. Maybe I should choose something else. Happy for any suggestion. > > Am I abusing to much C99 magic here? > > I don't think so. snmp and snmpd use similar constructs. I don't currently > have access to a gcc arch, so I can't check if old gcc is happy. If you > have such a machine running, it might be worth checking it is before commit. I did run it on sparc64 with gcc4. I guess if other bits in base use compound literals then it is probably fine there too. > ok > > two small nits below Issues fixed, will commit tomorrow. -- :wq Claudio
