On Tue, Nov 15 2022, Mathias Bavay <[email protected]> wrote: > Hi, > > Please find here attached a patch with minor touch up on > src/lib/libc/stdlib/getopt_long.c : > > * Added an SPDX license identifier;
As Theo answered, we don't use those identifiers (except sometimes in external source code added to the base system). > * moved the declarations of two variables in order to reduce their scope; We sometimes do this but 1. some people don't like much the idea 2. this change isn't worth a change/commit on its own (IMHO). Also, only unified diffs please (-u). See https://www.openbsd.org/faq/faq5.html#Diff > All the best, > > Mathias Bavay > > 1d0 > < // SPDX-License-Identifier: BSD-2-Clause > 133c132 > < int cyclelen, i, j, ncycle, nnonopts, nopts; > --- >> int cstart, cyclelen, i, j, ncycle, nnonopts, nopts, pos; > 145,146c144,145 > < const int cstart = panonopt_end+i; > < int pos = cstart; > --- >> cstart = panonopt_end+i; >> pos = cstart; > -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
