On Tue, Aug 30, 2022 at 04:47:30PM +0200, Martijn van Duren wrote: > So right now we disallow allocation of a region if a sub-region has the > subtree flag set. This logic is inverted compared to it's intention, > which is that if you allocate a region with subtree it should check that > the entire region below it is available (application.c:242 should say > "subtree" instead of "region->subtree"). > > However, since the subtree flag is intended for backends that are > normally only initialized on startup and we now have blocklist, chances > for overlap increase and could possible disable bigger regions than > intended. > > I think it's safe to remove this entire overlap check because of the > following reasoning: > - First the blocklist is loaded. This should prevent allocating > anything underneath it and expects things to be loaded on top of > it > - legacy (internal): This could have regions allocated over it and > should have blocklist regions underneath it > - agentx (as native backend): Same as legacy > - agentx (dynamic applications): Only get their chance when > everything already has been initialised and thus no risk of being > inserted below a "subtree" region, because that's being captured > by the first overlap check. > > OK?
This makes sense to me ok tb
