Hi Stuart,

Stuart Henderson wrote on Sat, Apr 23, 2022 at 06:52:46PM +0100:

> saves time if you want to ignore 11n-only devices. ok?

Adding useful information is good in general, but i can't really
comment on the content.

If you add a column to a -column list, usually you also want to update
the .Bl -column line.  Unless there are specific reasons to do it
otherwise, the .Bl -column line should usually repeat the longest
string in each column, for example:

  -.Bl -column "Chipset" "Spectrum" "MIMO" "Bus" -offset 6n
  +.Bl -column BCM43236 2GHz/5GHz Type MIMO SDMMC/USB -offset 6n

Both groff and mandoc use the number of columns specified in
the .Bl -column line to pick a visually pleasing spacing between
columns (in this case, 4n without updating the .Bl -column line
or 3n after updating it; in the case at hand, the effect is partially
compensated by the .Bl -column containing shorter strings rather
than the longest, which seems a bit confusing :).

While there, i suggest dropping the useless quoting.

Yours,
  Ingo


> Index: share/man/man4/bwfm.4
> ===================================================================
> RCS file: /cvs/src/share/man/man4/bwfm.4,v
> retrieving revision 1.16
> diff -u -p -r1.16 bwfm.4
> --- share/man/man4/bwfm.4     5 Jan 2022 17:39:24 -0000       1.16
> +++ share/man/man4/bwfm.4     23 Apr 2022 17:51:24 -0000
> @@ -35,29 +35,29 @@ as well as the bus attachments recognize
>  .Nm
>  driver:
>  .Bl -column "Chipset" "Spectrum" "MIMO" "Bus" -offset 6n
> -.It Em Chipset Ta Em Spectrum Ta Em MIMO Ta Em Bus
> -.It BCM43143 Ta 2GHz Ta 1x1 Ta SDMMC/USB
> -.It BCM43236 Ta 2GHz/5GHz Ta 2x2 Ta USB
> -.It BCM4324 Ta  2GHz/5GHz Ta 2x2 Ta SDMMC
> -.It BCM43242 Ta 2GHz/5GHz Ta 2x2 Ta USB
> -.It BCM4329 Ta  2GHz/5GHz Ta 2x2 Ta SDMMC
> -.It BCM4330 Ta  2GHz/5GHz Ta 2x2 Ta SDMMC
> -.It BCM4334 Ta  2GHz/5GHz Ta 2x2 Ta SDMMC
> -.It BCM43340 Ta 2GHz/5GHz Ta 1x1 Ta SDMMC
> -.It BCM43341 Ta 2GHz/5GHz Ta 1x1 Ta SDMMC
> -.It BCM4335 Ta  2GHz/5GHz Ta 1x1 Ta SDMMC
> -.It BCM43362 Ta 2GHz Ta 1x1 Ta SDMMC
> -.It BCM43364 Ta 2GHz Ta 1x1 Ta SDMMC
> -.It BCM4339 Ta  2GHz/5GHz Ta 1x1 Ta SDMMC
> -.It BCM43430 Ta 2GHz Ta 1x1 Ta SDMMC
> -.It BCM43455 Ta  2GHz/5GHz Ta 1x1 Ta SDMMC
> -.It BCM43456 Ta  2GHz/5GHz Ta 2x2 Ta SDMMC
> -.It BCM4350 Ta 2GHz/5GHz Ta 2x2 Ta PCI
> -.It BCM4354 Ta  2GHz/5GHz Ta 2x2 Ta SDMMC
> -.It BCM4356 Ta 2GHz/5GHz Ta 2x2 Ta PCI/SDMMC
> -.It BCM43569 Ta 2GHz/5GHz Ta 2x2 Ta USB
> -.It BCM43602 Ta 2GHz/5GHz Ta 3x3 Ta PCI
> -.It BCM4371 Ta 2GHz/5GHz Ta 2x2 Ta PCI
> +.It Em Chipset Ta Em Spectrum Ta Em Type Ta Em MIMO Ta Em Bus
> +.It BCM43143 Ta 2GHz Ta 11n Ta 1x1 Ta SDMMC/USB
> +.It BCM43236 Ta 2GHz/5GHz Ta 11n Ta 2x2 Ta USB
> +.It BCM4324 Ta  2GHz/5GHz Ta 11n Ta 2x2 Ta SDMMC
> +.It BCM43242 Ta 2GHz/5GHz Ta 11n Ta 2x2 Ta USB
> +.It BCM4329 Ta  2GHz/5GHz Ta 11n Ta 2x2 Ta SDMMC
> +.It BCM4330 Ta  2GHz/5GHz Ta 11n Ta 2x2 Ta SDMMC
> +.It BCM4334 Ta  2GHz/5GHz Ta 11n Ta 2x2 Ta SDMMC
> +.It BCM43340 Ta 2GHz/5GHz Ta 11n Ta 1x1 Ta SDMMC
> +.It BCM43341 Ta 2GHz/5GHz Ta 11n Ta 1x1 Ta SDMMC
> +.It BCM4335 Ta  2GHz/5GHz Ta 11ac Ta 1x1 Ta SDMMC
> +.It BCM43362 Ta 2GHz Ta 11n Ta 1x1 Ta SDMMC
> +.It BCM43364 Ta 2GHz Ta 11n Ta 1x1 Ta SDMMC
> +.It BCM4339 Ta  2GHz/5GHz Ta 11ac Ta 1x1 Ta SDMMC
> +.It BCM43430 Ta 2GHz Ta 11n Ta 1x1 Ta SDMMC
> +.It BCM43455 Ta  2GHz/5GHz Ta 11ac Ta 1x1 Ta SDMMC
> +.It BCM43456 Ta  2GHz/5GHz Ta 11ac Ta 2x2 Ta SDMMC
> +.It BCM4350 Ta 2GHz/5GHz Ta 11ac Ta 2x2 Ta PCI
> +.It BCM4354 Ta  2GHz/5GHz Ta 11ac Ta 2x2 Ta SDMMC
> +.It BCM4356 Ta 2GHz/5GHz Ta 11ac Ta 2x2 Ta PCI/SDMMC
> +.It BCM43569 Ta 2GHz/5GHz Ta 11ac Ta 2x2 Ta USB
> +.It BCM43602 Ta 2GHz/5GHz Ta 11ac Ta 3x3 Ta PCI
> +.It BCM4371 Ta 2GHz/5GHz Ta 11ac Ta 2x2 Ta PCI
>  .El
>  .Pp
>  These are the modes the

Reply via email to