Re: patch: if_iwx.c add support for ax201 with subsystem id 0x0030

[Stefan Sperling]

On Sat, Apr 09, 2022 at 04:29:42PM +0200, Stefan Sperling wrote:
> As sthen points out, please show sc_hw_rev without any of its bits
> masked out, with a patch like this:

Nevermind, I found a bug in my patch which most certainly
breaks your device.

Please try this on top of the patch I sent out, without any
other modifcations. Your device should work with this change.

diff 64e15b2294bce6a08025941cf9440784a6b2e1f2 /usr/src
blob - 9ffa40d1606fc261ed610984b82e0dbcada90340
file + sys/dev/pci/if_iwx.c
--- sys/dev/pci/if_iwx.c
+++ sys/dev/pci/if_iwx.c
@@ -9860,13 +9860,12 @@ iwx_attach(struct device *parent, struct device *self,
        case PCI_PRODUCT_INTEL_WL_22500_7:
        case PCI_PRODUCT_INTEL_WL_22500_8:
                if (sc->sc_hw_rev != IWX_CSR_HW_REV_TYPE_QUZ)
                        sc->sc_fwname = IWX_QU_B_HR_B_FW;
                else
                        sc->sc_fwname = IWX_QUZ_A_HR_B_FW;
-               sc->sc_fwname = IWX_QU_C_HR_B_FW;
                sc->sc_device_family = IWX_DEVICE_FAMILY_22000;
                sc->sc_integrated = 1;
                sc->sc_ltr_delay = IWX_SOC_FLAGS_LTR_APPLY_DELAY_1820;
                sc->sc_low_latency_xtal = 0;
                sc->sc_xtal_latency = 1820;
                sc->sc_tx_with_siso_diversity = 0;