Since the input is opened read-only I don't see the point in checking
the fclose() return value.  However, if you are going to do so, you
might as well combine it with the ferror() check.  E.g.

        if (ferror(fp) || fclose(fp) == EOF) {
                warn("%s", name);
                status = 1;
        }

Otherwise, OK.

 - todd

Reply via email to