On Fri, Jan 14, 2022 at 01:45:19PM +0000, Job Snijders wrote:
> Thanks Claudio,
>
> A question about stats below
>
> On Fri, Jan 14, 2022 at 10:29:20AM +0100, Claudio Jeker wrote:
> > @@ -1246,8 +1249,8 @@ main(int argc, char *argv[])
> > logx("Certificate revocation lists: %zu", stats.crls);
> > logx("Ghostbuster records: %zu", stats.gbrs);
> > logx("Repositories: %zu", stats.repos);
> > - logx("Cleanup: removed %zu files, %zu directories",
> > - stats.del_files, stats.del_dirs);
> > + logx("Cleanup: removed %zu files, %zu directories, %zu superfluous",
> > + stats.del_files, stats.del_dirs, stats.extra_files);
>
> The above stats message is not entirely clear to me, is something along
> these lines more precise?
>
> logx("Cleanup: removed %zu previously valid objects, %zu directories, %zu"
> " superfluous files", stats.del_files, stats.del_dirs,
> stats.extra_files);
I still need to think about this more. The way the numbers are calculated
is not what you suggested. Right now the delete numbers are including
files that where never valid, etc. It may make sense to spend some time
and fix the reporting so that the stats returned make sense.
I think we now have files in ta and valid that should be accounted
differently than file in rrdp and rsync. The latter are now mostly
temporary files (e.g. rsync will always be empty after a run).
I'll get the validated cache in and then we can bikeshed over this :)
--
:wq Claudio
