Last time when this value was bumped because I ran into SNMP problems
walking net-snmp because of string based indices in USM.
This time I want to bump them one more time because I found the
definition of the upper bound RFC 2578 section 7.1.3. This makes it
easier to parse agentx messages, which also have their upper bound
on 128.
I see no risk of fallout, since the previous bump only broke agentx
support in snmpd, which has since been removed. Nothing in ports is
using this code as far I know.
Memory footprint of snmpd only increases by a few 100KB, claudio@
only found on stack use of ber_oid in ldapd, so memory impact is
manageable.
Already discussed with claudio@
Iff OK tb@ promised to commit it at the same time as the libcrypto
bump to keep churn to a minimum.
OK?
martijn@
Index: ber.h
===================================================================
RCS file: /cvs/src/lib/libutil/ber.h,v
retrieving revision 1.4
diff -u -p -r1.4 ber.h
--- ber.h 29 Aug 2021 13:27:11 -0000 1.4
+++ ber.h 26 Oct 2021 10:14:26 -0000
@@ -80,8 +80,8 @@ struct ber {
#define BER_CLASS_MASK 0x3
/* common definitions */
-#define BER_MIN_OID_LEN 2 /* OBJECT */
-#define BER_MAX_OID_LEN 64 /* OBJECT */
+#define BER_MIN_OID_LEN 2 /* X.690 section 8.19.5
*/
+#define BER_MAX_OID_LEN 128 /* RFC 2578 section
7.1.3 */
#define BER_MAX_SEQ_ELEMENTS USHRT_MAX /* 65535 */
struct ber_oid {
Index: shlib_version
===================================================================
RCS file: /cvs/src/lib/libutil/shlib_version,v
retrieving revision 1.33
diff -u -p -r1.33 shlib_version
--- shlib_version 29 Aug 2021 13:27:11 -0000 1.33
+++ shlib_version 26 Oct 2021 10:14:26 -0000
@@ -1,2 +1,2 @@
-major=15
-minor=1
+major=16
+minor=0
