On Mon, Oct 25, 2021 at 07:50:46PM +0200, Claudio Jeker wrote:
> Refactor this code and instead of passing various things around just use
> globals.
ok with two small nits:
> @@ -560,14 +622,6 @@ proc_parser(int fd)
> if ((pfd.revents & POLLHUP))
> break;
>
> - /*
> - * Start with read events.
> - * This means that the parent process is sending us
> - * something we need to parse.
> - * We don't actually parse it til we have space in our
> - * outgoing buffer for responding, though.
> - */
> -
> if ((pfd.revents & POLLIN)) {
> b = io_buf_read(fd, &inbuf);
>
Could you zap the two tabs on the line after io_buf_read() while you're here?
[...]
> + parse_entity(&q, &msgq);
> +
> }
No empty line before the closing braces (or at least nuke the three tabs)
