Re: snmpd: s/SNMP_C_GETRESP/SNMP_C_RESPONSE

[Martijn van Duren]

On Thu, 2021-10-21 at 15:22 +0100, Stuart Henderson wrote:
> On 2021/10/21 15:08, Martijn van Duren wrote:
> > This one has been bothering me for a while.
> > 
> > OK?
> > 
> > martijn@
> > 
> > Index: smi.c
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/snmpd/smi.c,v
> > retrieving revision 1.28
> > diff -u -p -r1.28 smi.c
> > --- smi.c   4 Jan 2021 07:59:54 -0000       1.28
> > +++ smi.c   21 Oct 2021 14:06:40 -0000
> > @@ -377,7 +377,7 @@ smi_debug_elements(struct ber_element *r
> >             case SNMP_C_GETNEXTREQ:
> >                     fprintf(stderr, "nextreq");
> >                     break;
> > -           case SNMP_C_GETRESP:
> > +           case SNMP_C_RESPONSE:
> >                     fprintf(stderr, "getresp");
> 
> ok.
> 
> maybe s/getresp/response in the fprintf above too?
> 
Sure, but let's clean up nextreq while we're here.

> 
Index: smi.c
===================================================================
RCS file: /cvs/src/usr.sbin/snmpd/smi.c,v
retrieving revision 1.29
diff -u -p -r1.29 smi.c
--- smi.c       21 Oct 2021 14:33:13 -0000      1.29
+++ smi.c       21 Oct 2021 14:34:49 -0000
@@ -375,10 +375,10 @@ smi_debug_elements(struct ber_element *r
                        fprintf(stderr, "getreq");
                        break;
                case SNMP_C_GETNEXTREQ:
-                       fprintf(stderr, "nextreq");
+                       fprintf(stderr, "getnextreq");
                        break;
                case SNMP_C_RESPONSE:
-                       fprintf(stderr, "getresp");
+                       fprintf(stderr, "response");
                        break;
                case SNMP_C_SETREQ:
                        fprintf(stderr, "setreq");