On 2021/07/25 14:55, Jonathan Matthew wrote: > On Thu, Jul 22, 2021 at 10:45:17PM -0400, Ashton Fagg wrote: > > I have two devices here based on the JMicron JMB585 chipset. This diff > > adds the required pcidev IDs and sets disables native command queuing in > > the driver. FreeBSD does something similar for this device: > > > > https://github.com/freebsd/freebsd-src/commit/16b766eed443043f4216d50e40ba283e74f992c2 > > Can you explain how you came to the conclusion that you'd need to > disable NCQ? The FreeBSD commit you link to doesn't appear to do that > as they're not applying the AHCI_Q_NONCQ flag to these devices. > Does it not work with NCQ enabled? >
That FreeBSD commit prevents using their "hw.ahci.force" tunable on the device, it's used for attaching as AHCI to certain known chips even if they're set in legacy IDE mode. Does it work to just add the vid/pid to the ahci_devices[] array without a specific attach function? (like PCI_PRODUCT_ASMEDIA_ASM1061_SATA).
